dnf clean: Do not report an error on a nonexistent cache directory #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
reviewed
Sep 18, 2024
dnf5/commands/clean/clean.cpp
Outdated
| return; | ||
| } | ||
| throw std::runtime_error(libdnf5::utils::sformat( | ||
| _("Cannot iterate the cache directory: \"{}\": {}"), cachedir.string(), ec.message())); |
There was a problem hiding this comment.
Just nitpicking - how about removing the first colon from the message: _("Cannot iterate the cache directory \"{}\": {}"). It seems redundant to me.
There was a problem hiding this comment.
I changed the message.
ppisar
force-pushed
the
dnf_clean_to_ignore_missing_directory
branch
from
4ba7211
to
1e8e10e
Compare
If /var/cache/libdnf5 directory did not exist, "dnf clean all"
reported and error:
Cannot iterate the cache directory: "/var/cache/libdnf5"
This patch optimizes this case to no operation. If there is no cache,
there is nothing to remove.
If the iterator fails for a different reason, the message is ammended
with an operating system error message, explaining the cause.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2313032
ppisar
force-pushed
the
dnf_clean_to_ignore_missing_directory
branch
from
1e8e10e
to
39213e6
Compare
Merged
via the queue into
rpm-software-management:main
with commit Sep 19, 2024
117bc3e
14 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If /var/cache/libdnf5 directory did not exist, "dnf clean all" reported and error:
This patch optimizes this case to no operation. If there is no cache, there is nothing to remove.
If the iterator fails for a different reason, the message is ammended with an operating system error message, explaining the cause.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2313032